From: David Goulet <dgoulet@efficios.com>
Date: Mon, 10 Mar 2014 20:18:42 +0000 (-0400)
Subject: Fix: handle signed return value for snprintf
X-Git-Tag: v2.5.0-rc1~121
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=7e078ad1e690a390671a52e321276a03e3088fde;p=lttng-tools.git

Fix: handle signed return value for snprintf

Signed-off-by: David Goulet <dgoulet@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/save.c b/src/bin/lttng-sessiond/save.c
index 8599d2d18..2d8af3821 100644
--- a/src/bin/lttng-sessiond/save.c
+++ b/src/bin/lttng-sessiond/save.c
@@ -1425,6 +1425,7 @@ int save_session(struct ltt_session *session,
 		}
 		strncpy(config_file_path, provided_path, len);
 	} else {
+		ssize_t ret_len;
 		char *home_dir = utils_get_user_home_dir(
 			LTTNG_SOCK_GET_UID_CRED(creds));
 		if (!home_dir) {
@@ -1432,14 +1433,15 @@ int save_session(struct ltt_session *session,
 			goto end;
 		}
 
-		len = snprintf(config_file_path, PATH_MAX,
+		ret_len = snprintf(config_file_path, PATH_MAX,
 				DEFAULT_SESSION_HOME_CONFIGPATH, home_dir);
 		free(home_dir);
-		if (len < 0) {
+		if (ret_len < 0) {
 			PERROR("snprintf save session");
 			ret = LTTNG_ERR_SET_URL;
 			goto end;
 		}
+		len = ret_len;
 	}
 
 	/*