From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 7 Apr 2021 17:01:44 +0000 (-0400)
Subject: Fix: sessiond: error accounting: wrong sizeof argument cpu_counters
X-Git-Tag: v2.13.0-rc1~150
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=74f286be45611aa0a3e0a8fedfdee6c254a97ee6;p=lttng-tools.git

Fix: sessiond: error accounting: wrong sizeof argument cpu_counters

1452205 Wrong sizeof argument

The wrong sizeof value is used in an expression or as argument to a function. The result is an incorrect value that may cause unexpected program behaviors.

In create_uid_accounting_entry: The sizeof operator is invoked on the wrong argument (CWE-569)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I1912964bd1579f3b1ff013000848c28cea6a9d52
---

diff --git a/src/bin/lttng-sessiond/event-notifier-error-accounting.c b/src/bin/lttng-sessiond/event-notifier-error-accounting.c
index cb8380251..aee82742a 100644
--- a/src/bin/lttng-sessiond/event-notifier-error-accounting.c
+++ b/src/bin/lttng-sessiond/event-notifier-error-accounting.c
@@ -223,11 +223,11 @@ struct error_account_entry *create_uid_accounting_entry(
 		cpu_counter_fds[i] = -1;
 	}
 
-	cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(**cpu_counters));
+	cpu_counters = zmalloc(entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data *));
 	if (!cpu_counters) {
 		PERROR("Failed to allocate event notifier error counter lttng_ust_abi_object_data array: application uid = %d, application name = '%s', pid = %d, allocation size = %zu",
 				(int) app->uid, app->name, (int) app->pid,
-				entry->nr_counter_cpu_fds * sizeof(**cpu_counters));
+				entry->nr_counter_cpu_fds * sizeof(struct lttng_ust_abi_object_data *));
 		ret = -1;
 		goto error_counter_cpus_alloc;
 	}