From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Fri, 3 Jun 2016 18:05:21 +0000 (-0400)
Subject: Fix: lttng-relayd allow binding of privileged ports for non-root users
X-Git-Tag: v2.8.1~15
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=730a7a913cae1cb36dcf8d541f805f4247cb2b80;p=lttng-tools.git

Fix: lttng-relayd allow binding of privileged ports for non-root users

Non-root users could use authbind to bind to low-numbered ports.
Moreover, the check was inverted; !getuid() will only be true
for the root user.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-relayd/main.c b/src/bin/lttng-relayd/main.c
index a1e94dcbd..6ad656625 100644
--- a/src/bin/lttng-relayd/main.c
+++ b/src/bin/lttng-relayd/main.c
@@ -2793,15 +2793,6 @@ int main(int argc, char **argv)
 		goto exit_init_data;
 	}
 
-	/* Check if daemon is UID = 0 */
-	if (!getuid()) {
-		if (control_uri->port < 1024 || data_uri->port < 1024 || live_uri->port < 1024) {
-			ERR("Need to be root to use ports < 1024");
-			retval = -1;
-			goto exit_init_data;
-		}
-	}
-
 	/* Setup the thread apps communication pipe. */
 	if (create_relay_conn_pipe()) {
 		retval = -1;