From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Fri, 4 Sep 2015 05:12:53 +0000 (-0400)
Subject: Fix: use after free in channel release
X-Git-Tag: v2.5.6~1
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=6a4ad2df7977360185a5cc8a377902cdf4d63dd7;p=lttng-modules.git

Fix: use after free in channel release

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/lttng-abi.c b/lttng-abi.c
index a9e8d1d0..5bd7621f 100644
--- a/lttng-abi.c
+++ b/lttng-abi.c
@@ -1198,8 +1198,8 @@ int lttng_metadata_channel_release(struct inode *inode, struct file *file)
 	struct lttng_channel *channel = file->private_data;
 
 	if (channel) {
-		lttng_metadata_channel_destroy(channel);
 		fput(channel->session->file);
+		lttng_metadata_channel_destroy(channel);
 	}
 
 	return 0;