From: Mathieu Desnoyers Date: Tue, 17 May 2016 01:43:03 +0000 (-0400) Subject: Fix: illegal memory access in test_create_ust_event_exclusion X-Git-Tag: v2.9.0-rc1~209 X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=61a046d9171d0c59a27588191eaa807c32737b5d;p=lttng-tools.git Fix: illegal memory access in test_create_ust_event_exclusion Found by Coverity: CID 1243019 (#1 of 1): Buffer not null terminated (BUFFER_SIZE_WARNING)1. buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array ev.name of size 256 bytes might leave the destination string unterminated. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- diff --git a/tests/unit/test_ust_data.c b/tests/unit/test_ust_data.c index 58f76435e..d81169572 100644 --- a/tests/unit/test_ust_data.c +++ b/tests/unit/test_ust_data.c @@ -38,7 +38,7 @@ #define RANDOM_STRING_LEN 11 /* Number of TAP tests in this file */ -#define NUM_TESTS 14 +#define NUM_TESTS 15 /* For error.h */ int lttng_opt_quiet = 1; @@ -156,7 +156,8 @@ static void test_create_ust_event_exclusion(void) /* make a wildcarded event name */ name = get_random_string(); name[strlen(name) - 1] = '*'; - strncpy(ev.name, name, LTTNG_SYMBOL_NAME_LEN); + ok(lttng_strncpy(ev.name, name, LTTNG_SYMBOL_NAME_LEN) == 0, + "Validate string length"); ev.type = LTTNG_EVENT_TRACEPOINT; ev.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;