From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 21 Apr 2021 19:31:38 +0000 (-0400)
Subject: Clean-up: lttng: add-trigger: silence coverity warning
X-Git-Tag: v2.13.0-rc1~58
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=55c6294d70e804e5ee7371f389d7cb786979b706;p=lttng-tools.git

Clean-up: lttng: add-trigger: silence coverity warning

CID 1452634 (#1 of 1): Resource leak (RESOURCE_LEAK)
23. leaked_storage: Variable error going out of scope leaks the storage
it points to.

The code path shown by Coverity does not appear reachable, but this
fixes the warning nonetheless.

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I9682616b123de108c5717cee2c17349212f224d5
---

diff --git a/src/bin/lttng/commands/add_trigger.c b/src/bin/lttng/commands/add_trigger.c
index d460c0ffb..10a7944df 100644
--- a/src/bin/lttng/commands/add_trigger.c
+++ b/src/bin/lttng/commands/add_trigger.c
@@ -1499,8 +1499,8 @@ struct lttng_action *handle_action_notify(int *argc, const char ***argv)
 error:
 	lttng_action_destroy(action);
 	action = NULL;
-	free(error);
 end:
+	free(error);
 	lttng_rate_policy_destroy(policy);
 	argpar_state_destroy(state);
 	argpar_item_destroy(item);