From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 23 Jun 2020 03:35:02 +0000 (-0400)
Subject: Fix: lttng: leak of userspace probe path on listing
X-Git-Tag: v2.13.0-rc1~568
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=4df1f2d4355df325341578644db615b840eaa116;p=lttng-tools.git

Fix: lttng: leak of userspace probe path on listing

realpath() returns a malloc'ed string when `resolved_path` is NULL.
`binary_path` can be safely free'd after it is printed.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ic35862f3275f58274ae2572e1d6be736f8a2107e
---

diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c
index 372a71dad..e96fe35dc 100644
--- a/src/bin/lttng/commands/list.c
+++ b/src/bin/lttng/commands/list.c
@@ -273,7 +273,7 @@ static void print_userspace_probe_location(struct lttng_event *event)
 	case LTTNG_USERSPACE_PROBE_LOCATION_TYPE_FUNCTION:
 	{
 		const char *function_name;
-		const char *binary_path;
+		char *binary_path;
 
 		MSG("%sType: Function", indent8);
 		function_name = lttng_userspace_probe_location_function_get_function_name(location);
@@ -292,12 +292,14 @@ static void print_userspace_probe_location(struct lttng_event *event)
 			MSG("%sLookup method: INVALID LOOKUP TYPE ENCOUNTERED", indent8);
 			break;
 		}
+
+		free(binary_path);
 		break;
 	}
 	case LTTNG_USERSPACE_PROBE_LOCATION_TYPE_TRACEPOINT:
 	{
 		const char *probe_name, *provider_name;
-		const char *binary_path;
+		char *binary_path;
 
 		MSG("%sType: Tracepoint", indent8);
 		probe_name = lttng_userspace_probe_location_tracepoint_get_probe_name(location);
@@ -313,6 +315,8 @@ static void print_userspace_probe_location(struct lttng_event *event)
 			MSG("%sLookup method: INVALID LOOKUP TYPE ENCOUNTERED", indent8);
 			break;
 		}
+
+		free(binary_path);
 		break;
 	}
 	default: