From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Date: Tue, 29 Sep 2009 03:15:21 +0000 (-0400)
Subject: urcu-qsbr: implement list_move algorithm
X-Git-Tag: v0.1~10
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=4d7033404d9671de36bec4a0a79c7c52546bc257;p=userspace-rcu.git

urcu-qsbr: implement list_move algorithm

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
---

diff --git a/urcu-qsbr.c b/urcu-qsbr.c
index 7889506..f002c34 100644
--- a/urcu-qsbr.c
+++ b/urcu-qsbr.c
@@ -97,39 +97,49 @@ static void internal_urcu_unlock(void)
 /*
  * synchronize_rcu() waiting. Single thread.
  */
-static void wait_gp(struct urcu_reader *index)
+static void wait_gp(void)
 {
-	uatomic_dec(&gp_futex);
-	smp_mb(); /* Write futex before read reader_gp */
-	if (!rcu_gp_ongoing(&index->ctr)) {
-		/* Read reader_gp before write futex */
-		smp_mb();
-		/* Callbacks are queued, don't wait. */
-		uatomic_set(&gp_futex, 0);
-	} else {
-		/* Read reader_gp before read futex */
-		smp_rmb();
-		if (uatomic_read(&gp_futex) == -1)
-			futex(&gp_futex, FUTEX_WAIT, -1,
-			      NULL, NULL, 0);
-	}
+	/* Read reader_gp before read futex */
+	smp_rmb();
+	if (uatomic_read(&gp_futex) == -1)
+		futex(&gp_futex, FUTEX_WAIT, -1,
+		      NULL, NULL, 0);
 }
 
 static void wait_for_quiescent_state(void)
 {
-	struct urcu_reader *index;
+	LIST_HEAD(qsreaders);
+	int wait_loops = 0;
+	struct urcu_reader *index, *tmp;
 
 	if (list_empty(&registry))
 		return;
 	/*
 	 * Wait for each thread rcu_reader_qs_gp count to become 0.
 	 */
-	list_for_each_entry(index, &registry, head) {
-		int wait_loops = 0;
+	for (;;) {
+		wait_loops++;
+		if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) {
+			uatomic_dec(&gp_futex);
+			/* Write futex before read reader_gp */
+			smp_mb();
+		}
+
+		list_for_each_entry_safe(index, tmp, &registry, head) {
+			if (!rcu_gp_ongoing(&index->ctr))
+				list_move(&index->head, &qsreaders);
+		}
 
-		while (rcu_gp_ongoing(&index->ctr)) {
-			if (wait_loops++ == RCU_QS_ACTIVE_ATTEMPTS) {
-				wait_gp(index);
+		if (list_empty(&registry)) {
+			if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) {
+				/* Read reader_gp before write futex */
+				smp_mb();
+				uatomic_set(&gp_futex, 0);
+			}
+			break;
+		} else {
+			if (wait_loops == RCU_QS_ACTIVE_ATTEMPTS) {
+				wait_gp();
 			} else {
 #ifndef HAS_INCOHERENT_CACHES
 				cpu_relax();
@@ -139,6 +149,8 @@ static void wait_for_quiescent_state(void)
 			}
 		}
 	}
+	/* put back the reader list in the registry */
+	list_splice(&qsreaders, &registry);
 }
 
 /*