From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 26 Sep 2012 02:03:47 +0000 (-0400)
Subject: Fix: relayd: possible NULL ptr deref, memory leak, accept fd leak
X-Git-Tag: v2.1.0-rc4~4
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=4b7f17b22c323c74554f7026304aa6c00a1ee434;p=lttng-tools.git

Fix: relayd: possible NULL ptr deref, memory leak, accept fd leak

- relay_cmd was not freed on error.
- newsock is a pointer. A pointer is always > 0. (unsigned comparison)
- if / else if  could lead to newsock to be dereferenced while NULL.
- missing lttcomm_destroy_sock on newsock on setsockopt error.
  Memory and FD leak.

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
---

diff --git a/src/bin/lttng-relayd/main.c b/src/bin/lttng-relayd/main.c
index fdddcbe6e..15e2b2266 100644
--- a/src/bin/lttng-relayd/main.c
+++ b/src/bin/lttng-relayd/main.c
@@ -472,12 +472,6 @@ void *relay_thread_listener(void *data)
 	struct lttng_poll_event events;
 	struct lttcomm_sock *control_sock, *data_sock;
 
-	/*
-	 * Get allocated in this thread, enqueued to a global queue, dequeued and
-	 * freed in the worker thread.
-	 */
-	struct relay_command *relay_cmd = NULL;
-
 	DBG("[thread] Relay listener started");
 
 	control_sock = relay_init_sock(control_uri);
@@ -544,7 +538,13 @@ restart:
 				ERR("socket poll error");
 				goto error;
 			} else if (revents & LPOLLIN) {
-				struct lttcomm_sock *newsock = NULL;
+				/*
+				 * Get allocated in this thread,
+				 * enqueued to a global queue, dequeued
+				 * and freed in the worker thread.
+				 */
+				struct relay_command *relay_cmd;
+				struct lttcomm_sock *newsock;
 
 				relay_cmd = zmalloc(sizeof(struct relay_command));
 				if (relay_cmd == NULL) {
@@ -554,16 +554,19 @@ restart:
 
 				if (pollfd == data_sock->fd) {
 					newsock = data_sock->ops->accept(data_sock);
-					if (newsock < 0) {
+					if (!newsock) {
 						PERROR("accepting data sock");
+						free(relay_cmd);
 						goto error;
 					}
 					relay_cmd->type = RELAY_DATA;
 					DBG("Relay data connection accepted, socket %d", newsock->fd);
-				} else if (pollfd == control_sock->fd) {
+				} else {
+					assert(pollfd == control_sock->fd);
 					newsock = control_sock->ops->accept(control_sock);
-					if (newsock < 0) {
+					if (!newsock) {
 						PERROR("accepting control sock");
+						free(relay_cmd);
 						goto error;
 					}
 					relay_cmd->type = RELAY_CONTROL;
@@ -573,6 +576,8 @@ restart:
 						&val, sizeof(int));
 				if (ret < 0) {
 					PERROR("setsockopt inet");
+					lttcomm_destroy_sock(newsock);
+					free(relay_cmd);
 					goto error;
 				}
 				relay_cmd->sock = newsock;