From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 25 Nov 2020 17:58:27 +0000 (-0500)
Subject: Fix: filter validator: refuse string and star glob input to bitwise operation
X-Git-Tag: v2.13.0-rc1~104
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=4ac5fbb7966e7a6ee4a0cb68c49713bc8c05206c;p=lttng-modules.git

Fix: filter validator: refuse string and star glob input to bitwise operation

The validator refuses input ax=string,bx=unknown, but accepts input
ax=unknown,bx=string. Both inputs should be refused.

The same goes for the error glob input.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/src/lttng-filter-validator.c b/src/lttng-filter-validator.c
index f117eadf..9057ee8a 100644
--- a/src/lttng-filter-validator.c
+++ b/src/lttng-filter-validator.c
@@ -215,8 +215,6 @@ int bin_op_bitwise_check(struct vstack *stack, filter_opcode_t opcode,
 		case REG_DOUBLE:
 			goto error_type;
 		case REG_TYPE_UNKNOWN:
-		case REG_STRING:
-		case REG_STAR_GLOB_STRING:
 		case REG_S64:
 			goto unknown;
 		}