From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Wed, 4 Apr 2018 16:20:28 +0000 (-0400)
Subject: Check return value of cds_lfht_destroy
X-Git-Tag: v2.11.0-rc1~286
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=3b68d0a3fdf213b4078b80380186aa78670d2712;p=lttng-tools.git

Check return value of cds_lfht_destroy

Bubbling up the error is not an option here. Print and error an move on.

CID 1388096:  Error handling issues  (CHECKED_RETURN)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/notification-thread-events.c b/src/bin/lttng-sessiond/notification-thread-events.c
index 6a7477aff..fe2d0826b 100644
--- a/src/bin/lttng-sessiond/notification-thread-events.c
+++ b/src/bin/lttng-sessiond/notification-thread-events.c
@@ -397,10 +397,14 @@ static
 void session_info_destroy(void *_data)
 {
 	struct session_info *session_info = _data;
+	int ret;
 
 	assert(session_info);
 	if (session_info->channel_infos_ht) {
-		cds_lfht_destroy(session_info->channel_infos_ht, NULL);
+		ret = cds_lfht_destroy(session_info->channel_infos_ht, NULL);
+		if (ret) {
+			ERR("Channel information hash table destroy");
+		}
 	}
 	free(session_info->name);
 	free(session_info);