From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Tue, 1 Mar 2022 14:09:04 +0000 (-0500)
Subject: Fix: lttng-ctl: uninitialized pointer read
X-Git-Tag: v2.13.5~35
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=33aaae1ca51f961133d86d686b62a00e80cb4def;p=lttng-tools.git

Fix: lttng-ctl: uninitialized pointer read

Reported by Coverity:

    CID 1475822: Uninitialized pointer read (UNINIT)
    Using uninitialized value reply._fd_handles.array.size when calling lttng_payload_reset.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ied7f5de61d736e8d8f9c869a36322262a4d79cd5
---

diff --git a/src/lib/lttng-ctl/lttng-ctl.c b/src/lib/lttng-ctl/lttng-ctl.c
index 089c9c1f8..012ba13b0 100644
--- a/src/lib/lttng-ctl/lttng-ctl.c
+++ b/src/lib/lttng-ctl/lttng-ctl.c
@@ -2416,14 +2416,14 @@ int lttng_list_events(struct lttng_handle *handle,
 				(const char *) &lsm, 0, sizeof(lsm));
 	unsigned int nb_events = 0;
 
+	lttng_payload_init(&reply);
+
 	/* Safety check. An handle and channel name are mandatory. */
 	if (handle == NULL || channel_name == NULL) {
 		ret = -LTTNG_ERR_INVALID;
 		goto end;
 	}
 
-	lttng_payload_init(&reply);
-
 	/* Initialize command parameters. */
 	lsm.cmd_type = LTTNG_LIST_EVENTS;
 	ret = lttng_strncpy(lsm.session.name, handle->session_name,