From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Fri, 27 Mar 2015 19:52:00 +0000 (-0400)
Subject: Fix: leak on error in lttng-crash
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=309fc9bf0c244ed47c4d7c3a47119e596a40eb73;p=lttng-tools.git

Fix: leak on error in lttng-crash

Found by Coverity:
** CID 1291945:  Resource leaks  (RESOURCE_LEAK)
/src/bin/lttng-crash/lttng-crash.c: 769 in copy_crash_data()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-crash/lttng-crash.c b/src/bin/lttng-crash/lttng-crash.c
index 793877d9d..4f1efe96d 100644
--- a/src/bin/lttng-crash/lttng-crash.c
+++ b/src/bin/lttng-crash/lttng-crash.c
@@ -766,7 +766,8 @@ int copy_crash_data(const struct lttng_crash_layout *layout, int fd_dest,
 	readlen = lttng_read(fd_src, buf, src_file_len);
 	if (readlen < 0) {
 		PERROR("Error reading input file");
-		return -1;
+		ret = -1;
+		goto end;
 	}
 
 	prod_offset = crash_get_field(layout, buf, prod_offset);