From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 11 Jul 2012 22:23:12 +0000 (-0400)
Subject: Fix: The session list count should provide unique identifiers
X-Git-Tag: v2.0.4~3
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=2a09e9fb3029858cd04ce36471bc4a9c9d7b6624;p=lttng-tools.git

Fix: The session list count should provide unique identifiers

Never decrement it.

Reported-by: Amer Alhalabi <amer.alhalabi@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/session.c b/src/bin/lttng-sessiond/session.c
index bcdd78d50..13abe424c 100644
--- a/src/bin/lttng-sessiond/session.c
+++ b/src/bin/lttng-sessiond/session.c
@@ -64,14 +64,12 @@ static unsigned int add_session_list(struct ltt_session *ls)
  * Delete a ltt_session structure to the global list.
  *
  * The caller MUST acquire the session list lock before.
+ * The session list count CANNOT be decremented, as it is used as unique
+ * identifier for the session in UST app hash table lookups.
  */
 static void del_session_list(struct ltt_session *ls)
 {
 	cds_list_del(&ls->list);
-	/* Sanity check */
-	if (ltt_session_list.count > 0) {
-		ltt_session_list.count--;
-	}
 }
 
 /*