From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 28 Feb 2023 17:44:55 +0000 (-0500)
Subject: Clean-up: coding style fix and missing method in lttng::ctl::error
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=20f5a9aeb6d1128823cc87023e1dada534baa1af;p=lttng-tools.git

Clean-up: coding style fix and missing method in lttng::ctl::error

Methods must not contain get/set for trivial accessors. get_code() is
renamed to code() to follow this guideline.

Moreover, the method was not implemented. It is marked as noexcept and
the _error_code member is made `const` as there is no reason for it to
be mutated.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: If0fca5cc91c1cb72fff183ee6d29588ff4b5c030
---

diff --git a/src/common/exception.hpp b/src/common/exception.hpp
index 30a403470..1efd80359 100644
--- a/src/common/exception.hpp
+++ b/src/common/exception.hpp
@@ -54,10 +54,14 @@ public:
 			const char *file_name,
 			const char *function_name,
 			unsigned int line_number);
-	lttng_error_code get_code() const;
+
+	lttng_error_code code() const noexcept
+	{
+		return _error_code;
+	}
 
 private:
-	lttng_error_code _error_code;
+	const lttng_error_code _error_code;
 };
 } /* namespace ctl */