From: David Goulet <dgoulet@efficios.com>
Date: Mon, 22 Sep 2014 14:55:52 +0000 (-0400)
Subject: Fix: possible file descriptor leak in error path
X-Git-Tag: v2.6.0-rc1~51
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=1ad31aec3288cc0a848d67afa59e753a6e0294cb;p=lttng-tools.git

Fix: possible file descriptor leak in error path

Fixes Coverity issue 1225086.

Signed-off-by: David Goulet <dgoulet@efficios.com>
---

diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c
index 96ccdb039..318896559 100644
--- a/src/bin/lttng/commands/list.c
+++ b/src/bin/lttng/commands/list.c
@@ -110,7 +110,7 @@ static void usage(FILE *ofp)
 static char *get_cmdline_by_pid(pid_t pid)
 {
 	int ret;
-	FILE *fp;
+	FILE *fp = NULL;
 	char *cmdline = NULL;
 	char path[20];	/* Can't go bigger than /proc/65535/cmdline */
 
@@ -130,9 +130,11 @@ static char *get_cmdline_by_pid(pid_t pid)
 	if (ret < 0) {
 		perror("fread proc list");
 	}
-	fclose(fp);
 
 end:
+	if (fp) {
+		fclose(fp);
+	}
 	return cmdline;
 }