From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Fri, 9 Apr 2021 14:59:09 +0000 (-0400)
Subject: tests: unit: action: notify
X-Git-Tag: v2.13.0-rc1~98
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=193cc91116c28031986caa999aba72de60a9a774;p=lttng-tools.git

tests: unit: action: notify

Note: the added tests are mostly toward testing of the firing policy
parameter.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I2aec17175ac2fed4cf21a15f998b24dfd353e77b
---

diff --git a/tests/unit/test_action.c b/tests/unit/test_action.c
index 697f1a710..e0f1aff24 100644
--- a/tests/unit/test_action.c
+++ b/tests/unit/test_action.c
@@ -30,17 +30,80 @@ int lttng_opt_quiet = 1;
 int lttng_opt_verbose;
 int lttng_opt_mi;
 
-#define NUM_TESTS 2
+#define NUM_TESTS 8
 
 static void test_action_notify(void)
 {
-	struct lttng_action *notify_action = NULL;
+	int ret;
+	enum lttng_action_status status;
+	struct lttng_action *notify_action = NULL,
+			    *notify_action_from_buffer = NULL;
+	struct lttng_firing_policy *policy = NULL, *default_policy;
+	struct lttng_payload payload;
+
+	lttng_payload_init(&payload);
+
+	/* To set. */
+	policy = lttng_firing_policy_every_n_create(100);
+	/* For comparison. */
+	default_policy = lttng_firing_policy_every_n_create(1);
+
+	assert(policy && default_policy);
 
 	notify_action = lttng_action_notify_create();
 	ok(notify_action, "Create notify action");
 	ok(lttng_action_get_type(notify_action) == LTTNG_ACTION_TYPE_NOTIFY,
 			"Action has type LTTNG_ACTION_TYPE_NOTIFY");
+
+	/* Validate the default policy for a notify action. */
+	{
+		const struct lttng_firing_policy *cur_policy = NULL;
+		status = lttng_action_notify_get_firing_policy(
+				notify_action, &cur_policy);
+		ok(status == LTTNG_ACTION_STATUS_OK &&
+						lttng_firing_policy_is_equal(
+								default_policy,
+								cur_policy),
+				"Default policy is every n=1");
+	}
+
+	/* Set a custom policy. */
+	status = lttng_action_notify_set_firing_policy(notify_action, policy);
+	ok(status == LTTNG_ACTION_STATUS_OK, "Set firing policy");
+
+	/* Validate the custom policy for a notify action. */
+	{
+		const struct lttng_firing_policy *cur_policy = NULL;
+		status = lttng_action_notify_get_firing_policy(
+				notify_action, &cur_policy);
+		ok(status == LTTNG_ACTION_STATUS_OK &&
+						lttng_firing_policy_is_equal(
+								policy,
+								cur_policy),
+				"Notify action policy get");
+	}
+
+	ret = lttng_action_serialize(notify_action, &payload);
+	ok(ret == 0, "Action notify serialized");
+
+	{
+		struct lttng_payload_view view =
+				lttng_payload_view_from_payload(
+						&payload, 0, -1);
+		(void) lttng_action_create_from_payload(
+				&view, &notify_action_from_buffer);
+	}
+	ok(notify_action_from_buffer,
+			"Notify action created from payload is non-null");
+
+	ok(lttng_action_is_equal(notify_action, notify_action_from_buffer),
+			"Serialized and de-serialized notify action are equal");
+
+	lttng_firing_policy_destroy(default_policy);
+	lttng_firing_policy_destroy(policy);
 	lttng_action_destroy(notify_action);
+	lttng_action_destroy(notify_action_from_buffer);
+	lttng_payload_reset(&payload);
 }
 
 int main(int argc, const char *argv[])