From: David Goulet <david.goulet@polymtl.ca>
Date: Thu, 24 Jun 2010 16:32:29 +0000 (-0400)
Subject: Fix directory creation mode. Unless umask is set to 0 the default umask of the system... 
X-Git-Tag: v1.9.1~575
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=18baca846d9957651fd0f10b6e5c9cdaa42ce748;p=lttng-ust.git

Fix directory creation mode. Unless umask is set to 0 the default umask of the system, commonly 022, will be used and thus it becomes impossible to get the 777 mode.
---

diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c
index d537eebf..fe299770 100644
--- a/libustcomm/ustcomm.c
+++ b/libustcomm/ustcomm.c
@@ -46,6 +46,7 @@ static int mkdir_p(const char *path, mode_t mode)
 
 	int retval = 0;
 	int result;
+	mode_t old_umask;
 
 	tmp = malloc(strlen(path) + 1);
 	if (tmp == NULL)
@@ -54,6 +55,7 @@ static int mkdir_p(const char *path, mode_t mode)
 	/* skip first / */
 	path_p = path+1;
 
+	old_umask = umask(0);
 	for(;;) {
 		while (*path_p != '/') {
 			if(*path_p == 0)
@@ -85,6 +87,7 @@ static int mkdir_p(const char *path, mode_t mode)
 	}
 
 	free(tmp);
+	umask(old_umask);
 	return retval;
 }
 
@@ -645,7 +648,8 @@ static int ensure_dir_exists(const char *dir)
 		/* ENOENT */
 		int result;
 
-		result = mkdir_p(dir, 0777);
+		/* mkdir mode to 0777 */
+		result = mkdir_p(dir, S_IRWXU | S_IRWXG | S_IRWXO);
 		if(result != 0) {
 			ERR("executing in recursive creation of directory %s", dir);
 			return -1;