From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Sat, 11 Feb 2023 01:29:39 +0000 (-0500)
Subject: Fix: rculfhash: urcu_die() takes positive error value
X-Git-Tag: v0.12.5~2
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=129e1dd6dbd0c9bf3785a7704356cd61522b6043;p=urcu.git

Fix: rculfhash: urcu_die() takes positive error value

Found by Coverity:

** CID 1504537:  Error handling issues  (NEGATIVE_RETURNS)
/src/rculfhash.c: 1934 in do_auto_resize_destroy_cb()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I6c130fc18fc36da8d0ed13188cc9415e7ee6104b
---

diff --git a/src/rculfhash.c b/src/rculfhash.c
index 93b0f2c..5fbd886 100644
--- a/src/rculfhash.c
+++ b/src/rculfhash.c
@@ -1908,7 +1908,7 @@ void do_auto_resize_destroy_cb(struct urcu_work *work)
 	ht->flavor->register_thread();
 	ret = cds_lfht_delete_bucket(ht);
 	if (ret)
-		urcu_die(ret);
+		urcu_die(-ret);
 	free_split_items_count(ht);
 	ret = pthread_mutex_destroy(&ht->resize_mutex);
 	if (ret)