From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Thu, 25 Mar 2021 19:18:13 +0000 (-0400)
Subject: compiler warning cleanup: is_signed_type: compare -1 to 1
X-Git-Tag: v2.13.0-rc1~183
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=0c6349626e82044473ea0b3f1ff5456d9a0cd53f;p=lttng-tools.git

compiler warning cleanup: is_signed_type: compare -1 to 1

Comparing -1 to 0 triggers compiler warnings (gcc -Wtype-limits and
-Wbool-compare) and Coverity warning "Macro compares unsigned to 0".

Comparing -1 to 1 instead takes care of silencing those warnings while
keeping the same behavior.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Id4aebce6eed214f0ccba2c0289fb3b034808cb64
---

diff --git a/src/common/macros.h b/src/common/macros.h
index e28250f7e..53f5f96c7 100644
--- a/src/common/macros.h
+++ b/src/common/macros.h
@@ -85,7 +85,7 @@ void *zmalloc(size_t len)
 #endif
 #endif
 
-#define is_signed(type) (((type) (-1)) < 0)
+#define is_signed(type) (((type) -1) < (type) 1)
 
 /*
  * Align value to the next multiple of align. Returns val if it already is a