From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Thu, 23 Aug 2018 22:55:38 +0000 (-0400)
Subject: Fix: notification channel not released on error path
X-Git-Tag: v2.11.0-rc1~116
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=0ba0fed6c4e13398af6f501aca7ab4f423a2fbf3;p=lttng-tools.git

Fix: notification channel not released on error path

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/lib/lttng-ctl/channel.c b/src/lib/lttng-ctl/channel.c
index 49a3684db..5214fe73a 100644
--- a/src/lib/lttng-ctl/channel.c
+++ b/src/lib/lttng-ctl/channel.c
@@ -430,14 +430,14 @@ lttng_notification_channel_has_pending_notification(
 	case LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_NOTIFICATION:
 		ret = enqueue_notification_from_current_message(channel);
 		if (ret) {
-			goto end;
+			goto end_unlock;
 		}
 		*_notification_pending = true;
 		break;
 	case LTTNG_NOTIFICATION_CHANNEL_MESSAGE_TYPE_NOTIFICATION_DROPPED:
 		ret = enqueue_dropped_notification(channel);
 		if (ret) {
-			goto end;
+			goto end_unlock;
 		}
 		*_notification_pending = true;
 		break;