From: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Date: Mon, 20 Apr 2020 18:27:45 +0000 (-0400)
Subject: format: AlignOperand introduces spaces
X-Git-Tag: v2.13.0-rc1~629
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=05ba77bc3dcfde2bbeb65c4f860839c63ebee98d;p=lttng-tools.git

format: AlignOperand introduces spaces

Observed issue
==============

t = tabs
s = space
tabs = 8 blanks

clang-format on this code will align with the operand using space.

consumed_len = sizeof(struct lttng_action_start_session_comm) +
t       ssssssscomm->session_name_len;

We want:
consumed_len = sizeof(struct lttng_action_start_session_comm) +
t       t       comm->session_name_len;

Solution
========

Explicitly set it to false.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Change-Id: I39bee6d82b20f4b6f9587a2911abb183de767d25
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/.clang-format b/.clang-format
index 3fc5c6737..91a23c9b0 100644
--- a/.clang-format
+++ b/.clang-format
@@ -2,7 +2,7 @@ AlignAfterOpenBracket: DontAlign
 AlignConsecutiveAssignments: false
 AlignConsecutiveDeclarations: false
 AlignEscapedNewlines: Left
-AlignOperands: true
+AlignOperands: false
 AlignTrailingComments: false
 AllowShortBlocksOnASingleLine: false
 AllowShortCaseLabelsOnASingleLine: false