From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Thu, 19 Sep 2019 14:10:31 +0000 (-0400)
Subject: Fix: provide errno as argument to urcu_die()
X-Git-Tag: v0.11.2~3
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=0365417a42044c072f363d29a0459ed3ad3ba143;p=urcu.git

Fix: provide errno as argument to urcu_die()

commit 1a990de3add "Fix: rculfhash worker needs to unblock to SIGRCU"
provides "ret" (-1) as argument to urcu_die(), but should rather provide
errno.

Reported by Coverity:

** CID 1405700:  Error handling issues  (NEGATIVE_RETURNS) /src/rculfhash.c: 2171 in cds_lfht_worker_init()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/src/rculfhash.c b/src/rculfhash.c
index 5b3c06b..811d515 100644
--- a/src/rculfhash.c
+++ b/src/rculfhash.c
@@ -2168,7 +2168,7 @@ static void cds_lfht_worker_init(struct urcu_workqueue *workqueue,
 		urcu_die(errno);
 	ret = sigdelset(&mask, SIGRCU);
 	if (ret)
-		urcu_die(ret);
+		urcu_die(errno);
 	ret = pthread_sigmask(SIG_SETMASK, &mask, NULL);
 	if (ret)
 		urcu_die(ret);