From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 12 Dec 2018 03:42:19 +0000 (-0500)
Subject: Fix: missing session reference release on kernel poll update
X-Git-Tag: v2.12.0-rc1~688
X-Git-Url: https://git.lttng.org./?a=commitdiff_plain;h=0318876b646d8f16bf063a59e157172739ca7899;p=lttng-tools.git

Fix: missing session reference release on kernel poll update

The iteration performed on all sessions in update_kernel_poll() does
not release the reference taken on the sessions. This causes the
session(s) to be leaked and prevents the shutdown of the session
daemon as it waits for all sessions to be destroyed before completing
its teardown.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/manage-kernel.c b/src/bin/lttng-sessiond/manage-kernel.c
index 35547743c..56bc0a93c 100644
--- a/src/bin/lttng-sessiond/manage-kernel.c
+++ b/src/bin/lttng-sessiond/manage-kernel.c
@@ -70,6 +70,7 @@ static int update_kernel_poll(struct lttng_poll_event *events)
 			DBG("Channel fd %d added to kernel set", channel->fd);
 		}
 		session_unlock(session);
+		session_put(session);
 	}
 	session_unlock_list();