Fix wrong return value on consumer socket creation
authorDavid Goulet <dgoulet@efficios.com>
Thu, 8 Mar 2012 23:10:38 +0000 (18:10 -0500)
committerDavid Goulet <dgoulet@efficios.com>
Thu, 8 Mar 2012 23:10:38 +0000 (18:10 -0500)
A failing call to mkdir() returned 0 instead of an error and was
creating a segfault later on since some memory was not initialized.

Signed-off-by: David Goulet <dgoulet@efficios.com>
src/bin/lttng-sessiond/main.c

index 076aac54b1824659fc1ba88f195795084b334856..6c7ed1fd6e7839926c65e58f28fbfc526bef48f0 100644 (file)
@@ -4252,10 +4252,11 @@ static int set_consumer_sockets(struct consumer_data *consumer_data,
        ret = mkdir(path, S_IRWXU);
        if (ret < 0) {
                if (errno != EEXIST) {
+                       PERROR("mkdir");
                        ERR("Failed to create %s", path);
                        goto error;
                }
-               ret = 0;
+               ret = -1;
        }
 
        /* Create the kconsumerd error unix socket */
This page took 0.028752 seconds and 4 git commands to generate.