capture: Replace FIXME by explanation of the limit
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 25 Nov 2020 18:44:38 +0000 (13:44 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 25 Nov 2020 18:44:38 +0000 (13:44 -0500)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
src/lttng-event-notifier-notification.c

index f675de4b1dbddbf6522928d79e810fe2323172dc..b67af11a77ecf0763801030346d6ceefc5f7ace1 100644 (file)
 #include <lttng/event-notifier-notification.h>
 
 /*
- * FIXME: this probably too low but it needs to be below 1024 bytes to avoid
- * the frame to be larger than the 1024 limit enforced by the kernel.
+ * The capture buffer size needs to be below 1024 bytes to avoid the
+ * frame to be larger than the 1024 limit enforced by the kernel. If we
+ * ever need to increase it, we will need to use a memory allocation
+ * scheme which allows allocating temporary memory chunks from the
+ * instrumentation sites. This could be done by adapting lttng
+ * tp-mempool to become nmi-safe and lock-free.
  */
 #define CAPTURE_BUFFER_SIZE 512
 
This page took 0.026095 seconds and 4 git commands to generate.