Fix: remove non-async-signal-safe fflush from ERR()

Commit ff1fedb9f2e8 ("usterr: make error reporting functions signal safe")
changed the logging printout mechanism to use patient_write() to a file
descriptor to ensure signal-safety of the ERR() logging mechanism.
However, the fflush(stderr) was left in place, although it was useless.
Unfortunately, fflush() is not async-signal-safe.

Fix this by removing this fflush() call.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I13754acd914c4a9f71014a1e332c3fb25197a669

diff --git a/src/common/logging.h b/src/common/logging.h
index c98644d87c8128c3caf2debe0e841f830c82ba22..e8762c69bdc5d01d3b363e07eb7452a859e6d9eb 100644 (file)
--- a/src/common/logging.h
+++ b/src/common/logging.h
@@ -126,7 +126,6 @@ do {                                                                        \
                ____buf[sizeof(____buf) - 1] = 0;                       \
                ust_patient_write(STDERR_FILENO, ____buf, strlen(____buf)); \
                errno = ____saved_errno;        /* signal-safety */     \
-               fflush(stderr);                                         \
        }                                                               \
 } while (0)