UST-wide warning fixes

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

diff --git a/libust/buffers.c b/libust/buffers.c
index 2e6a16181c25ceea46a8ba031eaa87037dfb6352..4e8004c65e042d73e70bb175874fd279d10ab29c 100644 (file)
--- a/libust/buffers.c
+++ b/libust/buffers.c
@@ -1243,6 +1243,10 @@ size_t ltt_write_event_header_slow(struct ust_channel *channel,
        case LTT_RFLAG_ID:
                header.id_time = 31 << LTT_TSC_BITS;
                break;
+       default:
+               WARN_ON_ONCE(1);
+               header.id_time = 0;
+               break;
        }
 
        header.id_time |= (u32)tsc & LTT_TSC_MASK;

diff --git a/libust/trace_event.c b/libust/trace_event.c
index 76628c55bc9933667e7a8be778f8ee6b2b0bc259..b54d361f2ae170e2bb64645b80ead4e51f149824 100644 (file)
--- a/libust/trace_event.c
+++ b/libust/trace_event.c
@@ -89,7 +89,7 @@ static void trace_event_get_iter(struct trace_event_iter *iter)
        int found = 0;
 
        found = lib_get_iter_trace_events(iter);
-end:
+
        if (!found)
                trace_event_iter_reset(iter);
 }

diff --git a/libust/tracectl.c b/libust/tracectl.c
index 25fa4d57ecde33954791d2bca5a21a4639af9a2d..25f84ccd0f033f2ec4ec38f40a589dae6cb05bc2 100644 (file)
--- a/libust/tracectl.c
+++ b/libust/tracectl.c
@@ -828,7 +828,7 @@ static void process_marker_cmd(int sock, int command,
 {
        struct ustcomm_header _reply_header;
        struct ustcomm_header *reply_header = &_reply_header;
-       int result;
+       int result = 0;
 
        memset(reply_header, 0, sizeof(*reply_header));
 

diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
index 739a22235198c2cc67668c029738c3baf41ac542..25c84ce0c48d36b20ef6369e8f0a60d5a2508293 100644 (file)
--- a/libustconsumer/libustconsumer.c
+++ b/libustconsumer/libustconsumer.c
@@ -445,7 +445,8 @@ static void destroy_buffer(struct ustconsumer_callbacks *callbacks,
 
 int consumer_loop(struct ustconsumer_instance *instance, struct buffer_info *buf)
 {
-       int result, read_result;
+       int result = 0;
+       int read_result;
        char read_buf;
 
        pthread_cleanup_push(decrement_active_buffers, instance);

diff --git a/snprintf/vfprintf.c b/snprintf/vfprintf.c
index d4953be28dca8f60024efabacda83e14cba4c157..1b8fba6721a8d1af6ed806959c1f2daf11c5d8e3 100644 (file)
--- a/snprintf/vfprintf.c
+++ b/snprintf/vfprintf.c
@@ -239,7 +239,7 @@ int ust_safe_vfprintf(LFILE *fp, const char *fmt0, va_list ap)
        int dprec;              /* a copy of prec if %[diouxX], 0 otherwise */
        int realsz;             /* field size expanded by dprec */
        int size;               /* size of converted field or string */
-       const char *xdigs;      /* digits for %[xX] conversion */
+       const char *xdigs = NULL;       /* digits for %[xX] conversion */
 #define NIOV 8
        struct __suio uio;      /* output information: summary */
        struct __siov iov[NIOV];/* ... and individual io vectors */

diff --git a/tests/register_test/register_test.c b/tests/register_test/register_test.c
index b593185e707f8d4c0f1cef55110f8453cda820b5..d5cd352afeaadd3362ab338d4e93d4479440c3c8 100644 (file)
--- a/tests/register_test/register_test.c
+++ b/tests/register_test/register_test.c
@@ -55,7 +55,7 @@ void tptest_probe(void *data, int anint)
 
 static void * register_thread_main(void *data)
 {
-       int ret, i, j = 0;
+       int i, j = 0;
 
        struct hello_trace_struct hello[HELLO_LENGTH];
 

diff --git a/tests/tap.c b/tests/tap.c
index bd7f81cc1eeeb61f455e8c756610e04b0a6d9acb..a54fd178d12f96cf9a32ac591754526c4149e4b4 100644 (file)
--- a/tests/tap.c
+++ b/tests/tap.c
@@ -37,7 +37,7 @@ static void *_tap_comment_stdout(void *_unused)
                if (strncmp(line, "_TAP", 4)) {
                        fprintf(normal_stdout, "# %s", line);
                } else {
-                       fprintf(normal_stdout, &line[4]);
+                       fprintf(normal_stdout, "# %s", &line[4]);
                }
        }
        pthread_exit(0);