Revert "LAVA: Use bash as first step to spawn a bash shell"

This reverts commit 6af14904ac64adeb74b494b7f7f27c83795d90f4.

Since the bash process does not return lava hang there.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>

diff --git a/lava/system-tests/kernel-tests.yml b/lava/system-tests/kernel-tests.yml
index ac0f39ed6a6ca0fbe20a86b4ef978cb9aad14c3c..a5db6231561c25fc7bf9f301b669acb6fa25ac1f 100644 (file)
--- a/lava/system-tests/kernel-tests.yml
+++ b/lava/system-tests/kernel-tests.yml
@@ -11,7 +11,6 @@ install:
                 - echo "$(pwd)/coredump/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
 run:
         steps:
-                - bash
                 - source /root/lttngvenv/activate
                 - cd /root/lttngvenv/src/lttng-tools
                 - lava-test-case build-test-suite --shell "make"

diff --git a/scripts/system-tests/lava2-submit.py b/scripts/system-tests/lava2-submit.py
index 0553b8810b64aa422d3a31b7f5142066a9f3980d..47cc61080416f31f386baf0269903218b963364f 100644 (file)
--- a/scripts/system-tests/lava2-submit.py
+++ b/scripts/system-tests/lava2-submit.py
@@ -157,7 +157,7 @@ def print_test_output(server, job):
                             print('----- TEST SUITE OUTPUT END -----')
                             break
 
-def get_vlttng_cmd(device, lttng_tools_commit, lttng_ust_commit=None, vlttng_path="/tmp/virtenv"):
+def get_vlttng_cmd(device, lttng_tools_commit, lttng_ust_commit=None):
 
     vlttng_cmd = 'vlttng --jobs=$(nproc) --profile urcu-master' \
                     ' --override projects.babeltrace.build-env.PYTHON=python3' \
@@ -173,13 +173,17 @@ def get_vlttng_cmd(device, lttng_tools_commit, lttng_ust_commit=None, vlttng_pat
                     ' --override projects.lttng-ust.checkout='+lttng_ust_commit+ \
                     ' --profile lttng-ust-no-man-pages'
 
+    if device is DeviceType.kvm:
+        vlttng_path = '/root/virtenv'
+    else:
+        vlttng_path = '/tmp/virtenv'
+
     vlttng_cmd += ' ' + vlttng_path
 
     return vlttng_cmd
 
 def main():
     nfsrootfs = "https://obj.internal.efficios.com/lava/rootfs/rootfs_amd64_trusty_2016-02-23-1134.tar.gz"
-    vlttng_path = '/tmp/virtenv'
     test_type = None
     parser = argparse.ArgumentParser(description='Launch baremetal test using Lava')
     parser.add_argument('-t', '--type', required=True)
@@ -218,12 +222,13 @@ def main():
 
     if test_type in [TestType.baremetal_benchmarks, TestType.baremetal_tests]:
         device_type = DeviceType.x86
+        vlttng_path = '/tmp/virtenv'
 
     else:
         device_type = DeviceType.kvm
+        vlttng_path = '/root/virtenv'
 
-    vlttng_cmd = get_vlttng_cmd(device_type, args.tools_commit,
-            args.ust_commit, vlttng_path=vlttng_path)
+    vlttng_cmd = get_vlttng_cmd(device_type, args.tools_commit, args.ust_commit)
 
     context = dict()
     context['DeviceType'] = DeviceType

diff --git a/scripts/system-tests/template_lava_job.jinja2 b/scripts/system-tests/template_lava_job.jinja2
index 599e58a0de3b8de9dd41838d7bda43f881b349a1..02201a14c94809f05733b369fcb536f35cce9a42 100644 (file)
--- a/scripts/system-tests/template_lava_job.jinja2
+++ b/scripts/system-tests/template_lava_job.jinja2
@@ -68,10 +68,8 @@ actions:
                     - groupadd tracing
                   {% if device_type == DeviceType.x86 %}
                     - mount /dev/sda1 /tmp
-                  {% elif device_type == DeviceType.kvm %}
-                    - mount /dev/sda /tmp
-                  {% endif %}
                     - rm -rf /tmp/*
+                  {% endif %}
                     - depmod -a
                     - locale-gen en_US.UTF-8
                     - apt-get update