Fix: destroy called twice on quit pipe

A consumer management thread can be launched successsfully and yet
still report an error encoutered during its initialization. If
such an error occurs, the cleanup function is invoked explicitly
in the error path and will be called again when the last reference
to the thread is released.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/manage-consumer.c b/src/bin/lttng-sessiond/manage-consumer.c
index 68c7d649b6d4ffff9fc2b59a40e2deda55385201..b710c61f80ed3d837aa03a92c511e0176e13fd10 100644 (file)
--- a/src/bin/lttng-sessiond/manage-consumer.c
+++ b/src/bin/lttng-sessiond/manage-consumer.c
@@ -471,7 +471,7 @@ bool launch_consumer_management_thread(struct consumer_data *consumer_data)
        wait_until_thread_is_ready(notifiers);
        lttng_thread_put(thread);
        if (notifiers->initialization_result) {
-               goto error;
+               return false;
        }
        return true;
 error: