Fix: missing statedump end event when block device listing available
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 14 May 2015 22:29:58 +0000 (18:29 -0400)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 14 May 2015 22:29:58 +0000 (18:29 -0400)
Incorrect handling of lttng_enumerate_block_devices() return value of 0
(which means "ok"), causing do_lttng_statedump() to return early.

To causes missing "lttng_statedump_end" in traces where block device
enumeration is available (CONFIG_KALLSYMS=y).

Reported-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
lttng-statedump-impl.c

index fcbdfa58e99427b03456af07d080bec985f2e9f2..dddd34ddf054cd25a12de60d95a7b3c26f45f62b 100644 (file)
@@ -522,6 +522,8 @@ int do_lttng_statedump(struct lttng_session *session)
                return ret;
        ret = lttng_enumerate_block_devices(session);
        switch (ret) {
+       case 0:
+               break;
        case -ENOSYS:
                printk(KERN_WARNING "LTTng: block device enumeration is not supported by kernel\n");
                break;
This page took 0.026526 seconds and 4 git commands to generate.