Fix: report bytecode_push failure when pushing symbol

The last use of bytecode_push's return value is not checked in
visit_node_load_expression_legacy().

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
index 74ec1a7157aa907610e18cf55098345cf79091a9..0e778562f99ab606f7f988dd4a16673a9c666e81 100644 (file)
--- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
+++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
@@ -295,6 +295,9 @@ int visit_node_load_expression_legacy(struct filter_parser_ctx *ctx,
        }
        ret = bytecode_push(&ctx->bytecode_reloc, symbol,
                                1, strlen(symbol) + 1);
+       if (ret) {
+               goto end;
+       }
        ret = 1;        /* legacy */
 end:
        free(insn);