Clean-up: common: uuid: uninitialized output parameter on error

1490018 Uninitialized scalar variable
The variable will contain an arbitrary value left from earlier
computations.

In lttng_uuid_from_str(char const *, std::​array<unsigned char, 16ul> &):
Use of an uninitialized variable (CWE-457)

Callers should not use the return parameter anyhow on error.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Idd863d219da840a0c291478733f7b931967a5e56

diff --git a/src/common/uuid.cpp b/src/common/uuid.cpp
index d4f0fb2bf1a748d6c9d087bbe83920702f5f430d..dd59edc31c79e532f6b14bb8caa84d731fa430ef 100644 (file)
--- a/src/common/uuid.cpp
+++ b/src/common/uuid.cpp
@@ -57,6 +57,7 @@ int lttng_uuid_from_str(const char *str_in, lttng_uuid& uuid_out)
        if (sscanf(str_in, LTTNG_UUID_FMT, LTTNG_UUID_SCAN_VALUES(uuid_scan)) !=
                        LTTNG_UUID_LEN) {
                ret = -1;
+               goto end;
        }
 
        uuid_out = uuid_scan;