Fix: ustctl: leak of event notifier data on communication error
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 17 Mar 2021 16:16:18 +0000 (12:16 -0400)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 17 Mar 2021 16:27:43 +0000 (12:27 -0400)
The `len != sizeof(*event_notifier)` error path does not free
the `event_notifier_data` even though it is not provided to the caller.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Ie3b4ebf77e8ca7205d802c6db67c23c347aa29df

liblttng-ust-ctl/ustctl.c

index 2a7c7d8a39ca0d3beadecdbab820fd90666b6999..d1e7eb4ef6143b4c9f3478ee2252a6f4d0c312b4 100644 (file)
@@ -590,6 +590,7 @@ int ustctl_create_event_notifier(int sock, struct lttng_ust_abi_event_notifier *
        /* Send struct lttng_ust_event_notifier */
        len = ustcomm_send_unix_sock(sock, event_notifier, sizeof(*event_notifier));
        if (len != sizeof(*event_notifier)) {
+               free(event_notifier_data);
                if (len < 0)
                        return len;
                else
This page took 0.025849 seconds and 4 git commands to generate.