Fix: perform lazy initialization of getenv common lib

The ust-dl wrapper ends up calling into the getenv common lib very early
from library constructors through use of dlopen by the tracepoint
instrumentation code.

This happens before the getenv common lib is explicitly initialized by
liblttng-ust's contructor.

Perform lazy initialization for those early use by constructor
scenarios.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I9f84bb776a62e03b11db0386e267df00eb165ddd

diff --git a/src/common/getenv.c b/src/common/getenv.c
index 1909f4cf912bd8f80ebf51e6fc5dd88bb866607c..23029508b161d126590d8ed3bbcc943e0e23aa8c 100644 (file)
--- a/src/common/getenv.c
+++ b/src/common/getenv.c
@@ -64,8 +64,11 @@ char *lttng_ust_getenv(const char *name)
        struct lttng_env *e;
        bool found = false;
 
-       if (!CMM_LOAD_SHARED(lttng_ust_getenv_is_init))
-               abort();
+       /*
+        * Perform lazy initialization of lttng_ust_getenv for early use
+        * by library constructors.
+        */
+       lttng_ust_getenv_init();
 
        for (i = 0; i < LTTNG_ARRAY_SIZE(lttng_env); i++) {
                e = &lttng_env[i];