lttng-ctl: health: remove unreachable condition

Coverity reports:
1442789 Logically dead code
The indicated dead code may have performed some action; that action will never occur.
In lttng_health_create_relayd: Code can never be reached because of a logical contradiction (CWE-561)

`path` is already checked for NULL before reaching the lttng_strncpy
call.

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ifce95c37a6fe7f914a3bbc5443171c511d3c211a

diff --git a/src/lib/lttng-ctl/lttng-ctl-health.c b/src/lib/lttng-ctl/lttng-ctl-health.c
index dc1516db5d0c7336371e10f0408927eef34a949e..3de74fd11009bee33df7710f2a6d25fdeda1d05f 100644 (file)
--- a/src/lib/lttng-ctl/lttng-ctl-health.c
+++ b/src/lib/lttng-ctl/lttng-ctl-health.c
@@ -231,8 +231,8 @@ struct lttng_health *lttng_health_create_relayd(const char *path)
                goto error;
        }
 
-       ret = lttng_strncpy(lh->health_sock_path, path ?: "",
-                           sizeof(lh->health_sock_path));
+       ret = lttng_strncpy(lh->health_sock_path, path,
+                       sizeof(lh->health_sock_path));
        if (ret) {
                goto error;
        }