Fix: Avoid potential null dereference with log4j loggers

Coverity warns that the return of LogManager.getCurrentLoggers()
can contain null elements. Add an explicit null check to skip those.

Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

diff --git a/liblttng-ust-java-agent/java/lttng-ust-agent-log4j/org/lttng/ust/agent/log4j/LttngLog4jAgent.java b/liblttng-ust-java-agent/java/lttng-ust-agent-log4j/org/lttng/ust/agent/log4j/LttngLog4jAgent.java
index 7dcff9ec4e582721eba2c85675d56671884aa390..6cb74f91b5516864c1cc35403a1e8ff525cdda38 100644 (file)
--- a/liblttng-ust-java-agent/java/lttng-ust-agent-log4j/org/lttng/ust/agent/log4j/LttngLog4jAgent.java
+++ b/liblttng-ust-java-agent/java/lttng-ust-agent-log4j/org/lttng/ust/agent/log4j/LttngLog4jAgent.java
@@ -55,6 +55,10 @@ class LttngLog4jAgent extends AbstractLttngAgent<LttngLogAppender> {
                @SuppressWarnings("unchecked")
                List<Logger> loggers = Collections.list(LogManager.getCurrentLoggers());
                for (Logger logger : loggers) {
+                       if (logger == null) {
+                               continue;
+                       }
+
                        /*
                         * Check if that logger has at least one LTTng log4j appender
                         * attached.