Clean-up: coding style fix and missing method in lttng::ctl::error
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 28 Feb 2023 17:44:55 +0000 (12:44 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 28 Feb 2023 17:44:55 +0000 (12:44 -0500)
Methods must not contain get/set for trivial accessors. get_code() is
renamed to code() to follow this guideline.

Moreover, the method was not implemented. It is marked as noexcept and
the _error_code member is made `const` as there is no reason for it to
be mutated.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: If0fca5cc91c1cb72fff183ee6d29588ff4b5c030

src/common/exception.hpp

index 30a40347050e8839c210e5bb461540f41186a92f..1efd80359654bb34de8af78708a131cd8b194db2 100644 (file)
@@ -54,10 +54,14 @@ public:
                        const char *file_name,
                        const char *function_name,
                        unsigned int line_number);
-       lttng_error_code get_code() const;
+
+       lttng_error_code code() const noexcept
+       {
+               return _error_code;
+       }
 
 private:
-       lttng_error_code _error_code;
+       const lttng_error_code _error_code;
 };
 } /* namespace ctl */
 
This page took 0.025857 seconds and 4 git commands to generate.