Use SIZE_MAX instead of -1ULL for size_t parameter
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 11 Mar 2017 13:43:09 +0000 (08:43 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 11 Mar 2017 13:43:09 +0000 (08:43 -0500)
strutils_star_glob_match() receives a size_t. Passing -1ULL truncates
the value implicitly on systems where size_t is 32-bit. It is cleaner to
use SIZE_T.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
liblttng-ust/lttng-events.c

index fa54a025a967226b5527384c9217849e97ea1c83..bfdae4fff1967d35c1286fd955bff8f4b11bd489 100644 (file)
@@ -635,8 +635,8 @@ int lttng_desc_match_star_glob_enabler(const struct lttng_event_desc *desc,
        unsigned int has_loglevel = 0;
 
        assert(enabler->type == LTTNG_ENABLER_STAR_GLOB);
-       if (!strutils_star_glob_match(enabler->event_param.name, -1ULL,
-                       desc->name, -1ULL))
+       if (!strutils_star_glob_match(enabler->event_param.name, SIZE_MAX,
+                       desc->name, SIZE_MAX))
                return 0;
        if (desc->loglevel) {
                loglevel = *(*desc->loglevel);
@@ -699,7 +699,7 @@ int lttng_desc_match_enabler(const struct lttng_event_desc *desc,
                                excluder_name = (char *) (excluder->excluder.names)
                                                + count * LTTNG_UST_SYM_NAME_LEN;
                                len = strnlen(excluder_name, LTTNG_UST_SYM_NAME_LEN);
-                               if (len > 0 && strutils_star_glob_match(excluder_name, len, desc->name, -1ULL))
+                               if (len > 0 && strutils_star_glob_match(excluder_name, len, desc->name, SIZE_MAX))
                                        return 0;
                        }
                }
This page took 0.026806 seconds and 4 git commands to generate.