Fix: pass NULL to config_load_session instead of an empty string
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 9 Aug 2016 17:03:00 +0000 (13:03 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 9 Aug 2016 17:06:27 +0000 (13:06 -0400)
The public lttng_load_session wrapper uses empty strings (strings
starting with \0) to express "any" session_name and the default
session load paths.

However, this is not expected by config_load_session which uses
NULLs to express these values.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/lib/lttng-ctl/load.c

index d1faf02693305541eb521eb27b1153e623835b4b..df712782f91026157c95c26896ad471f5dd0ef9e 100644 (file)
@@ -159,14 +159,18 @@ end:
 int lttng_load_session(struct lttng_load_session_attr *attr)
 {
        int ret;
+       const char *url, *session_name;
 
        if (!attr) {
                ret = -LTTNG_ERR_INVALID;
                goto end;
        }
 
-       ret = config_load_session(attr->input_url, attr->session_name,
-                       attr->overwrite, 0);
+       url = attr->input_url[0] != '\0' ? attr->input_url : NULL;
+       session_name = attr->session_name[0] != '\0' ?
+                       attr->session_name : NULL;
+
+       ret = config_load_session(url, session_name, attr->overwrite, 0);
 
 end:
        return ret;
This page took 0.025932 seconds and 4 git commands to generate.