]> git.lttng.org Git - userspace-rcu.git/commitdiff
Fix: rculfhash: urcu_die() takes positive error value
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 11 Feb 2023 01:29:39 +0000 (20:29 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 11 Feb 2023 01:30:32 +0000 (20:30 -0500)
Found by Coverity:

** CID 1504537:  Error handling issues  (NEGATIVE_RETURNS)
/src/rculfhash.c: 1934 in do_auto_resize_destroy_cb()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I6c130fc18fc36da8d0ed13188cc9415e7ee6104b

src/rculfhash.c

index 93b0f2c66c9ae02b58a58bbbc741aa2bfaa9d7d3..5fbd88682e49e60235b56e842f9e514ae2564962 100644 (file)
@@ -1908,7 +1908,7 @@ void do_auto_resize_destroy_cb(struct urcu_work *work)
        ht->flavor->register_thread();
        ret = cds_lfht_delete_bucket(ht);
        if (ret)
-               urcu_die(ret);
+               urcu_die(-ret);
        free_split_items_count(ht);
        ret = pthread_mutex_destroy(&ht->resize_mutex);
        if (ret)
This page took 0.030278 seconds and 4 git commands to generate.