Fix: relayd: missing session unlock on error path

1475890 Missing unlock May result in deadlock if there is another
attempt to acquire the lock.

In viewer_get_new_streams(relay_connection *): Missing a release of a
lock on a path (CWE-667)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I66de344f5f39ac85bf8db93cf39a07d0c6cf7694

diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c
index f1e440640aa465c9389f8061174e10657fa32a47..37bdfc2e5a2c5326ae0104523d6c4d3c2994a98a 100644 (file)
--- a/src/bin/lttng-relayd/live.c
+++ b/src/bin/lttng-relayd/live.c
@@ -1185,7 +1185,7 @@ int viewer_get_new_streams(struct relay_connection *conn)
                 * 'ret' to close the connection.
                 */
                response.status = htobe32(LTTNG_VIEWER_NEW_STREAMS_ERR);
-               goto send_reply;
+               goto send_reply_unlock;
        }
        send_streams = 1;
        response.status = htobe32(LTTNG_VIEWER_NEW_STREAMS_OK);