Fix: statedump: check whether "files" is NULL, RCU semantic fix
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 26 Jun 2014 18:52:03 +0000 (14:52 -0400)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 26 Jun 2014 18:54:43 +0000 (14:54 -0400)
commitd561ecfbc9a17ca47721cd6d7742d2b1835f8ae3
tree4aa01dcee8e29e2cac01c7d13c76b4bd13911263
parentcfcee1c794ba05c6f7e4b0f7e630f9ca5cba935f
Fix: statedump: check whether "files" is NULL, RCU semantic fix

We need to check if p->files is NULL before passing it to
files_fdtable(). Moreover, since the fdt is now protected by RCU, we
have to assume it can change between the read from
lttng_enumerate_task_fd() and the internal in-kernel read in
iterate_fd(). Therefore, move this rcu dereference into
lttng_dump_one_fd(), and perform the appropriate checks on max fds.

Fixes #799

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
lttng-statedump-impl.c
This page took 0.026344 seconds and 4 git commands to generate.