Fix: create/destroy a splice_pipe per stream
authorJulien Desfossez <jdesfossez@efficios.com>
Wed, 12 Nov 2014 23:36:17 +0000 (18:36 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 17 Nov 2014 18:43:06 +0000 (13:43 -0500)
commitbabec7b7e1eb3c23e1751d68463fb189e3088679
tree73e7325ea4931ddfa715c0503dcd5b0bc8daca36
parente37c37c64ff100d236ecc0436c802e5917880ca1
Fix: create/destroy a splice_pipe per stream

We had a per-thread splice_pipe (one for data and one for metadata), but
in case of error, we would end up filling the write side of the pipe and
never emptying it. This could lead to leaking data from one session to
the other, but also to stall the consumer trying to splice into a full
pipe.

Now we create a splice_pipe per-stream, so it is destroyed when the
session is destroyed.

Fixes: #726
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/consumer-stream.c
src/common/consumer.c
src/common/consumer.h
src/common/kernel-consumer/kernel-consumer.c
This page took 0.025787 seconds and 4 git commands to generate.