]> git.lttng.org Git - lttng-tools.git/commit
Fix: sessiond: notification-thread: add to pollset fails silently
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 20 Nov 2024 16:44:12 +0000 (16:44 +0000)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 29 Nov 2024 19:01:45 +0000 (14:01 -0500)
commit92edc464c775feee6e04fcc48dd61855d6adf2e5
tree5d0fba64732a9b37d34e2a767e8d62dee4f7a975
parent8120a16d3132c3649c9a6084f202f29e70659bf4
Fix: sessiond: notification-thread: add to pollset fails silently

Noticed when reviewing the code, so I don't have a reproducer
for the issue. However, the "ADD_TRACER_EVENT_SOURCE" command
returns LTTNG_OK even when the notification thread fails to add
the tracer event source to the poll set.

The error path properly performs the requisite clean-up, but
the command emitter will be under the impression that the command
succeeded. In doing so, it will most likely use the
"REMOVE_TRACER_EVENT_SOURCE" at a later point which will cause
a failed assertion to hit when the `source_element` isn't found.

Change-Id: I4a400d6affa21d2c2247ecfb845ca1e4aa730b5d
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-sessiond/notification-thread-events.cpp
This page took 0.029532 seconds and 4 git commands to generate.