Fix: create/destroy a splice_pipe per stream
authorJulien Desfossez <jdesfossez@efficios.com>
Wed, 12 Nov 2014 23:36:17 +0000 (18:36 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 17 Nov 2014 18:43:00 +0000 (13:43 -0500)
commit76ad88ce0969e585a5aa479f249db1a484fe9208
tree875ef405c48666b3b632ed420301a13356f69505
parent0ac9b15db22d9817dd77f4c34673508e993f60ca
Fix: create/destroy a splice_pipe per stream

We had a per-thread splice_pipe (one for data and one for metadata), but
in case of error, we would end up filling the write side of the pipe and
never emptying it. This could lead to leaking data from one session to
the other, but also to stall the consumer trying to splice into a full
pipe.

Now we create a splice_pipe per-stream, so it is destroyed when the
session is destroyed.

Fixes: #726
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/consumer-stream.c
src/common/consumer.c
src/common/consumer.h
src/common/kernel-consumer/kernel-consumer.c
This page took 0.026176 seconds and 4 git commands to generate.