tests: append to AM_CFLAGS instead of overriding it
authorSimon Marchi <simon.marchi@efficios.com>
Mon, 3 Feb 2020 22:38:23 +0000 (17:38 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 19 Feb 2020 22:47:41 +0000 (17:47 -0500)
commit4f2a40d56c5cf84efab7c4cce066152b1ce7676a
tree57d4c44d66905a399d76dbb7dac0311eb7b50894
parent109c31feaa3f7242f4e24e50f7f47f16f97a09a6
tests: append to AM_CFLAGS instead of overriding it

The Makefiles modified by this patch currently override the AM_CFLAGS
value, which means that anything put in AM_CFLAGS by configure (for
example, the warning flags) is lost.

I believe the intention is to add some flags to CFLAGS, so modify them
such that they append instead of override.

notification/Makefile.am overrides AM_LDFLAGS with nothing.  It feels
like it was not the intention to actually clear that variable, but
rather that it is just the by-product of a copy paste.  If it was really
the intention to clear the value of AM_LDFLAGS, there would have been a
comment to explain it, right?

Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I4ef926d9135b16200e5f17d09461506a5e955068
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
tests/regression/tools/notification/Makefile.am
tests/utils/testapp/userspace-probe-elf-binary/Makefile.am
This page took 0.0256 seconds and 4 git commands to generate.