]> git.lttng.org Git - lttng-ust.git/commit
Fix: Correct `numa_available` return code checks
authorKienan Stewart <kstewart@efficios.com>
Fri, 22 Nov 2024 14:17:50 +0000 (09:17 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mon, 25 Nov 2024 16:04:49 +0000 (11:04 -0500)
commit270321d89d7e218e90ba5ebcda2bceb3ffe3a2f7
treedfbd0a91f0ddf49609dcb0cb741fa0af3cfd43b2
parentc0de10a2dab6d5cc6568e12c0ad3b97d85e0dc6b
Fix: Correct `numa_available` return code checks

As of 0.9.2, the documentation has been updated to state that
`numa_available` returns `-1` on failure[1]. In
previous versions the documentation stated "any negative value",
although `-1` appears to be the only error return value as far back as
v0.5[2].

`0` should be considered a successful response when checking the
return code of this function.

[1]: https://github.com/numactl/numactl/blob/4eee394215cde8420e5d3a75fcad02f27940bd6d/numa.3#L154
[2]: https://github.com/numactl/numactl/blob/0ab0fa63dac14d08ab967ec9916122aada0fc6b0/libnuma.c#L190

Change-Id: Ic44274971f39ea76082246692c1d6d7bc1515c2f
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
src/common/counter/shm.c
src/common/ringbuffer/shm.c
This page took 0.028709 seconds and 4 git commands to generate.