From 1169e6ed1727035eeab8839b0a867880f0a85951 Mon Sep 17 00:00:00 2001
From: Kienan Stewart <kstewart@efficios.com>
Date: Fri, 31 Jan 2025 16:55:19 -0500
Subject: [PATCH] tests: Preserve serial test log.d folder when the stdout has
 'not ok'
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Change-Id: Iee886ffb5fc45f6c6e79e9204f72713d3cb31d65
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---
 tests/regression/tests.serial | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/regression/tests.serial b/tests/regression/tests.serial
index c936309f6..8075a6ab7 100755
--- a/tests/regression/tests.serial
+++ b/tests/regression/tests.serial
@@ -168,7 +168,9 @@ def run_test(test_script):
     with open(str(test_log), "w") as f:
         logging.debug("Wrote test output to '{}'".format(str(test_log)))
         f.write(stdout)
-    if return_code == 0:
+
+    # Some test scripts can fail but still return a zero exit code
+    if return_code == 0 and len(TAP_NOT_OK_LINE_RE.findall(stdout)) == 0:
         if test_log_dir:
             shutil.rmtree(str(test_log_dir))
     return (stdout, return_code)
-- 
2.39.5