Mathieu Desnoyers [Thu, 3 Sep 2015 04:38:26 +0000 (00:38 -0400)]
Fix: relayd: don't check new metadata on get packet
We only care about this when we get the next index. There may be new
metadata that appears between get next index and get packet, but it
should not matter.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 13:26:30 +0000 (09:26 -0400)]
Fix: relayd: don't check for new streams in get packet
Only needed in get next index.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 13:00:50 +0000 (09:00 -0400)]
Fix: ask new streams HUP
Test closed streams for content to check for HUP.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 11:53:07 +0000 (07:53 -0400)]
Fix: reply error if get packet vstream fails
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 11:47:08 +0000 (07:47 -0400)]
Fix: relayd reply error to client if cannot find viewer stream
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 11:43:16 +0000 (07:43 -0400)]
Fix: relayd reply with error if cannot find metadata
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Aug 2015 02:50:09 +0000 (22:50 -0400)]
Fix: ust-app: protect app socket protocol with lock
Many threads can access the application socket (cmd handling thread and
application handling thread) concurrently. Therefore, we need to protect
it with a mutex.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 24 Aug 2015 19:03:35 +0000 (15:03 -0400)]
Fix: add missing rcu_barrier at end of sessiond main
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 24 Aug 2015 19:03:20 +0000 (15:03 -0400)]
Fix: add missing rcu_barrier at end of consumer main
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 24 Aug 2015 18:41:42 +0000 (14:41 -0400)]
Fix: app cmd leak on sessiond exit
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 23 Aug 2015 19:52:26 +0000 (12:52 -0700)]
Fix: relayd live don't send incomplete stream list
Sample the "closed" flag with session lock held.
Also, if the session connection is closed while we attach to it, reply
with HUP, because there are risks of attaching to an incomplete session
(e.g. the metadata stream could be already closed).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 23 Aug 2015 15:58:50 +0000 (08:58 -0700)]
Fix: consumer timer misses RCU thread registration
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 23 Aug 2015 05:01:36 +0000 (22:01 -0700)]
Fix: sessiond consumer thread should register as RCU thread
Fixes RCU race where objects are accessed by this thread under RCU
read-side lock after free. Since this thread is not a registered RCU
reader, the read-side lock has no effect.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 23 Aug 2015 03:14:44 +0000 (20:14 -0700)]
Fix: don't chain RCU free
We only do a single rcu_barrier() on teardown of sessiond. Therefore, if
we chain call_rcu, they may not all be executed before exit.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 23 Aug 2015 02:58:09 +0000 (19:58 -0700)]
Fix: free metadata cache after grace period in consumer
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Aug 2015 21:44:59 +0000 (14:44 -0700)]
Fix: sessiond vs consumerd push/get metadata deadlock
We need to unlock the registry while we push metadata to break a
circular dependency between the consumerd metadata lock and the sessiond
registry lock. Indeed, pushing metadata to the consumerd awaits that it
gets pushed all the way to relayd, but doing so requires grabbing the
metadata lock. If a concurrent metadata request is being performed by
consumerd, this can try to grab the registry lock on the sessiond while
holding the metadata lock on the consumer daemon. Those push and pull
schemes are performed on two different bidirectionnal communication
sockets.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Aug 2015 21:13:48 +0000 (14:13 -0700)]
Fix: streamline ret/errno of run_as()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 3 Sep 2015 03:01:21 +0000 (23:01 -0400)]
Fix: Double unlock on error path
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 3 Sep 2015 02:57:40 +0000 (22:57 -0400)]
Fix: Relay daemon ownership and reference counting
The ownership and reference counting of the relay daemon is unclear and
buggy in many ways. It is the cause of memory corruptions, double-free,
leaks, segmentation faults, observed in various conditions.
Fix this situation by introducing a clear ownership and reference
counting scheme for this daemon.
See doc/relayd-architecture.txt for details.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 3 Sep 2015 19:09:00 +0000 (15:09 -0400)]
Accept uid and gid parameters in utils_mkdir()/utils_mkdir_recursive()
utils_mkdir* utils may now be use in immediate or "run_as" mode.
This is done since some of the code shared between daemons calls
run_as directly, which doesn't support negative uid/gid (which we use
to mean "run as current user").
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Aug 2015 07:29:52 +0000 (00:29 -0700)]
Fix: reference counting of consumer output
The UST app session has a reference on the consumer output object, but
it belongs to the UST session. Implement a refcounting scheme to ensure
it is not freed before all users are done using it.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 18 Aug 2015 01:47:53 +0000 (18:47 -0700)]
Fix: sessiond add missing socket close
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 16 Aug 2015 21:56:57 +0000 (17:56 -0400)]
Fix: sessiond should not error on channel creation vs app exit
We should not report an error when creating a channel if the application
is exiting concurrently.
Also, remove an inappropriate assert() in ust_app_create_event_glb: it
is possible to have a channel lookup fail if channel/event creation
occurs concurrently with an application exit.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 16 Aug 2015 21:10:22 +0000 (17:10 -0400)]
Fix: sessiond ust-app session teardown race
Add a deleted flag within the ust app session which is raised (with ust
app session lock held) at delete, and checked within each RCU traversal,
again with ust app session lock held.
This takes care of races between teardown of an application (unregister)
and execution of commands which are accessing the app session
concurrently.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 1 Sep 2015 15:58:38 +0000 (11:58 -0400)]
Only display agent loglevel if the loglevel type is not ALL
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Aug 2015 22:53:51 +0000 (18:53 -0400)]
Initialize default log level of events on load
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Aug 2015 22:32:16 +0000 (18:32 -0400)]
Don't assume that Log4j and JUL share the same log level mappings
We explicitly set the log level of Log4j events to
LTTNG_LOGLEVEL_LOG4J_ALL instead of relying on the fact that
LTTNG_LOGLEVEL_LOG4J_ALL and LTTNG_LOGLEVEL_JUL_ALL are mapped to the
same value.
The resulting additional branch does not seem to incur a significant
performance penalty and, as such, is deemed acceptable.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 31 Aug 2015 20:00:22 +0000 (16:00 -0400)]
Allow the creation of JUL, Log4j and Python channels
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 22:55:52 +0000 (18:55 -0400)]
Fix: Save tracker as part of UST and Kernel domains only
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 22:50:39 +0000 (18:50 -0400)]
Fix: Memory leak of agent
agent_destroy() has a comment which indicates that it does _not_
destroy the pointer passed to it and it seems that agents are
never realeased under any code path whatsoever.
There does not seem to be an instance where an agent is allocated on
the stack.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 22:32:47 +0000 (18:32 -0400)]
Fix: Memory leak of agent event internals
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 21:44:41 +0000 (17:44 -0400)]
Save filter expression as part of agent events and save them
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 21:43:45 +0000 (17:43 -0400)]
Fix: UTF-8 characters may be stored on up to 4 bytes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 30 Aug 2015 21:37:41 +0000 (17:37 -0400)]
Prevent the addition of UST events to agent channels
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Aug 2015 18:53:26 +0000 (14:53 -0400)]
Don't save log level in session configuration when unneeded
Saving the log level of events in session configurations when "ALL" log
levels are enabled may confuse both users and programs working with
session configurations.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 21:26:58 +0000 (17:26 -0400)]
Fix: Propagate filter status of kernel events to client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 20:53:24 +0000 (16:53 -0400)]
Fix: Save kernel event filter when saving session configuration
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Aug 2015 15:52:34 +0000 (11:52 -0400)]
Fix: Mention Python as part of enable-event's usage()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:04:12 +0000 (12:04 -0400)]
Fix: typo in error message
writting -> writing
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:03:38 +0000 (12:03 -0400)]
Add agent domains to lttng enable-event usage()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:30 +0000 (12:00 -0400)]
Report memory allocation failure when copying filter bytecode
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 16:00:05 +0000 (12:00 -0400)]
Fix: cmd_enable_event must return positive error codes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 15:37:48 +0000 (11:37 -0400)]
Save filter expressions as part of agent events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Aug 2015 15:31:45 +0000 (11:31 -0400)]
Add agent domains to the enable-event section of LTTNG(1)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 16:24:18 +0000 (12:24 -0400)]
Prevent disable event on internal UST events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Aug 2015 16:17:01 +0000 (12:17 -0400)]
Skip internal events when saving a session configuration
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 03:43:21 +0000 (23:43 -0400)]
Hide internal events from session daemon clients
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:27:34 +0000 (00:27 -0400)]
Prevent the use of reserved UST event names
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Aug 2015 04:26:28 +0000 (00:26 -0400)]
Tag events created as side-effect of agent events as internal
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 19 Aug 2015 18:17:40 +0000 (14:17 -0400)]
Fix: assert(0) when listing Python events with MI
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Fri, 21 Aug 2015 15:44:28 +0000 (11:44 -0400)]
Fix: set GLOBAL buffer type for kernel domain in list
MI is using the list command reponse's buffer type, even when listing
the kernel domain. Not setting .buf_type here results in MI reporting a
wrong buffer type for the kernel domain.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 22:02:21 +0000 (18:02 -0400)]
Fix: take RCU read-side lock within hash table functions
After review, a great deal of caller sites miss the RCU read-side lock
when using the hash table modification functions. This is a case where
having a slight performance degradation might be worthwhile if we can be
a bit more stability. So instead of playing whack-a-mole, add the RCU
read-side lock in the hash table modification functions to ensure
protection from ABA.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Aug 2015 21:45:40 +0000 (17:45 -0400)]
Tests: Adapt MI test to change in track/untrack behaviour
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 12 Aug 2015 20:08:16 +0000 (16:08 -0400)]
Fix: Improve the error reporting of the track/untrack command
This patch adds feedback when a track/untrack command is successful and
specific messages on errors. It also changes the behavior when tracking
an already tracked PID or untracking a PID that is not tracked from an
error to a warning with a successful exit code.
Fixes: #898
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Aug 2015 18:37:14 +0000 (14:37 -0400)]
Tests: Fix flacky clock-plugin test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:15 +0000 (19:00 -0400)]
Build: look for python >= 3.0 when building python bindings
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 6 Aug 2015 23:00:14 +0000 (19:00 -0400)]
Build: rename use_python to python_binding
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 21:15:45 +0000 (17:15 -0400)]
Fix: regression tests
Fix racy session/relayd wait-after-kill scheme.
Fix racy live test where application may not have generated events yet
when we attach to the live trace.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 29 Jul 2015 21:57:52 +0000 (17:57 -0400)]
Fix: tests: stderr not correctly redirected
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Tue, 11 Aug 2015 20:29:30 +0000 (16:29 -0400)]
Fix: TimeoutExpired in Python tests not defined globally
The `TimeoutExpired` exception is used in multiple locations
throughout the Python tests. However, it needs to be used as
`subprocess.TimeoutExpired` given that it is only defined in that
module.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 23 Jul 2015 01:49:21 +0000 (21:49 -0400)]
Tests: ust: clock override plugin
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 9 Apr 2015 20:38:24 +0000 (16:38 -0400)]
Test: save/load: pid_tracker basic test
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 31 Mar 2015 21:15:36 +0000 (17:15 -0400)]
Save/load: pid_tracker feature.
Xml schema updated
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Sat, 28 Mar 2015 22:00:09 +0000 (18:00 -0400)]
Test: mi: track/untrack feature
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 3 Apr 2015 21:15:43 +0000 (17:15 -0400)]
Util: xml_extract: add node_exist option
The node_exist argument permit a more flexible way to extract informations
within test suites. We can check the presence of a node and not only list
the content of a final node.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 19:15:27 +0000 (15:15 -0400)]
Mi: track/untrack: validation
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 16:53:49 +0000 (12:53 -0400)]
Docs: Grammar fixes in mi_lttng.xsd
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 11 Aug 2015 16:44:06 +0000 (12:44 -0400)]
Fix: Ensure a valid command error code is returned by track/untrack
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 11 Aug 2015 19:14:11 +0000 (15:14 -0400)]
Mi: track/untrack/listing
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 21:01:37 +0000 (17:01 -0400)]
Fix: intialization of ust_metadata_poll_pipe to garbage value
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Aug 2015 20:17:02 +0000 (16:17 -0400)]
Fix "allocator sizeof operand mismatch" warning
Addresses benign scan-build waring:
Result of 'realloc' is converted to a pointer of type 'char *',
which is incompatible with sizeof operand type 'char **'
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Tue, 4 Aug 2015 22:29:35 +0000 (18:29 -0400)]
Fix: incorrect script name in python logging test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 1 Apr 2015 00:10:07 +0000 (20:10 -0400)]
Tests: Python agent: update after Python agent refactoring
This patch makes the tests follow the recent refactoring
of the LTTng-UST Python agent.
You need both python2 and python3 in your $PATH to run this
test now (since the agent is compatible with both versions
of Python).
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 02:03:29 +0000 (22:03 -0400)]
Fix: Discard disable event command filter payload
liblttng-ctl sends both the filter expression and filter bytecode
whenever lttng_disable_event_ext() is used _or_ when it is used
implicitly by lttng_disable_event() on an Agent domain (Log4j,
JUL or Python).
As of now, the session daemon ignores this filter payload.
However, on some rare occasions (the frequency of which depends
on the system's configuration and load), the second call to
sendmsg() done by liblttng-ctl could block and return an error
when the session daemon closed the socket (EPIPE).
This fix ensures the payload is received and discarded by the
session daemon, which in turn allows the client to handle the
session daemon's reply to the command.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Aug 2015 01:26:34 +0000 (21:26 -0400)]
Fix: Use MSG_NOSIGNAL when calling sendmsg()
Applications using the liblttng-ctl library are most probably
not expecting the SIGPIPE signal which can be triggered by
sendmsg() on a closed socket. Use the MSG_NOSIGNAL flag to
handle such cases gracefully.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Aug 2015 19:52:37 +0000 (15:52 -0400)]
Fix: test_mi test
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Aug 2015 20:48:16 +0000 (16:48 -0400)]
Set registration done Agent command version back to 0
The command version was used to indicate a workaround introducing a
change of behavior in a minor version. 2.6 was the only version affected
by this bug.
Fixes #884
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Aug 2015 20:45:00 +0000 (16:45 -0400)]
Fix: Don't send agent disable event command twice
The session daemon sends a "disable event" command to agents for each
event, enabled or not, on session destroy. This had no adverse effect
of the Java agent since it suffered from an unrelated bug which ignored
any refcount decrementation.
This fix bumps the command version to "1" to indicate that this behavior
is fixed on the session daemon's end.
Fixes #884
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Sat, 1 Aug 2015 19:20:50 +0000 (15:20 -0400)]
Fix: incorrect variable being checked in libc-wrapper test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 16:46:56 +0000 (12:46 -0400)]
Fix: Initialize global agent_apps_ht_by_sock on session daemon launch
Reported-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 24 Jul 2015 21:42:59 +0000 (17:42 -0400)]
Fix: pids should be numbers only
Ruled out cases: word, number+word, word+number, number+word+number
Ex: foo, 123foo, foo123, 123foo123
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 20:16:23 +0000 (16:16 -0400)]
Fix: Mishandled NULL short options in lttng-sessiond
set_option() ignores any option which has no short option
defined.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 20:13:18 +0000 (16:13 -0400)]
Use popt "required_argument" and "no_argument" constants
Use popt's provided constants for the "has_arg" field of long
options instead of hardcoding 0 and 1 everywhere.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 18:54:24 +0000 (14:54 -0400)]
Fix: Mishandled NULL short options in utils_generate_optstring()
The NULL character is used to indicate that no short option is
available for a given command.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 26 Jul 2015 00:09:23 +0000 (20:09 -0400)]
Fix: only launch a new session daemon for the "create" command
Fixes #859
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 23:50:22 +0000 (19:50 -0400)]
Fix 'daemon' typo in lttng-ctl-pc.in description
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 21:48:12 +0000 (17:48 -0400)]
Fix: clean-up agent app hash table from the main sessiond thread
The agent application hash table, which is allocated by the session
daemon's main thread, is free'd from the agent application registration
thread.
This leads to a number of interesting scenarios under which the agent
app registration thread may encounter an error, thus tearing itself down
and freeing the agent_apps_ht_by_sock hash table. Of course, nothing then
prevents the client processing thread from accessing this invalidated hash
table to list, enable or disable agent events which leads to crashes or
assertions hitting in ht_match_reg_uid().
However, it is not necessary for the agent app registration thread to
encounter an error for this to prove problematic. As shown in bug #893,
the session daemon's teardown will assert on a NULL key in
ht_match_reg_uid() whenever it is performed while a JUL, Log4J or Python
event is still enabled in a session. This happens because the session
daemon's clean-up triggers the destruction of all sessions. The destruction
of those sessions would access the free'd agent_apps_ht_by_sock to disable
the registered agent events.
Fixes #893
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 21:38:29 +0000 (17:38 -0400)]
Fix: Remove undocumented session daemon short options
Fixes #864
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 20:28:50 +0000 (16:28 -0400)]
Log userspace application hash table allocation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 20:24:05 +0000 (16:24 -0400)]
Fix: RCU read-side lock released too early in destroy_agent_app
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 25 Jul 2015 19:54:19 +0000 (15:54 -0400)]
Fix: misleading logging statement in agent_find_event
An _event_ is not found, not an agent.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 24 Jul 2015 22:01:02 +0000 (18:01 -0400)]
Fix: Unhandled domain option condition in list_agent_events
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 24 Jul 2015 21:54:47 +0000 (17:54 -0400)]
Fix: Crash on lttng list -j/-l/-p when no events are present
The lttng client will free an uninitialized pointer whenever a the
lttng list command is invoked on a domain which involves the log4j,
JUL or Python agents.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 17:13:09 +0000 (13:13 -0400)]
Document relay_add_stream RCU locking
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 17:04:05 +0000 (13:04 -0400)]
Fix: Unbalanced rcu_read_unlock() on stream file creation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 17:02:47 +0000 (13:02 -0400)]
Fix: Unbalanced rcu_read_unlock() on directory creation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 17:00:56 +0000 (13:00 -0400)]
Fix: Document the locking assumptions of ctf_trace_find_by_path()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 16 Jul 2015 16:58:44 +0000 (12:58 -0400)]
Fix: Memory leak in relay_add_stream error path
Failing to allocate a struct ctf_trace results in the leak of a stream's
path and channel name.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Partha Pratim Mukherjee [Sat, 25 Jul 2015 07:55:19 +0000 (13:25 +0530)]
Fix: set session should not set non-existent session
set-session does not check the existence of a session before setting
it as the current session. Fix it so that it gives error for a
non-existent session.
Fixes #885
Signed-off-by: Partha Pratim Mukherjee <ppm.floss@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 30 Jul 2015 20:51:03 +0000 (16:51 -0400)]
Rename Python agent event name to omit "user"
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.04163 seconds and 4 git commands to generate.